Pre-Submission Checklist

[ x] Commit message has the format required by CONTRIBUTING guide
[ x] Commits are split per component (core, individual modules, libs, utils, ...)
[ x] Each component has a single commit (if not, squash them into one commit)
[ x] No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

[x ] Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

[x ] PR should be backported to stable branches
[x ] Tested changes locally
Related to issue #XXXX (replace XXXX with an open issue number)

Description

When cnxcc receives a message wih a registered CID (for example in a re-INVITE) it saves as a new call and this is a problem:

cnxcc store 2 times the same call and it discounts credit for both
when the call is finished, cnxcc only remove one record and the other continues discounting credit.
when credit is finished (of an non active call), all active calls are killed

An example:
kamcmd> cnxcc.check_client test
id:0,confirmed:no,local_consumed_amount:0.004800,global_consumed_amount:3.126200,local_max_amount:30.000000,global_max_amount:30.000000,call_id:41211f7e0a65b41c4ca7181b18db0f1e@185.47.15.56:5080,start_timestamp:0,inip:1,finp:1,connect:0.000000,cps:0.004800;
id:1,confirmed:no,local_consumed_amount:0.004800,global_consumed_amount:3.126200,local_max_amount:30.000000,global_max_amount:30.000000,call_id:41211f7e0a65b41c4ca7181b18db0f1e@185.47.15.56:5080,start_timestamp:0,inip:1,finp:1,connect:0.000000,cps:0.004800;
id:2,confirmed:no,local_consumed_amount:0.000200,global_consumed_amount:3.126200,local_max_amount:30.000000,global_max_amount:30.000000,call_id:5e911ab1452cf1a3165af5262b519977@185.47.15.56:5080,start_timestamp:0,inip:1,finp:1,connect:0.000000,cps:0.000200;
id:3,confirmed:no,local_consumed_amount:0.000200,global_consumed_amount:3.126200,local_max_amount:30.000000,global_max_amount:30.000000,call_id:5e911ab1452cf1a3165af5262b519977@185.47.15.56:5080,start_timestamp:0,inip:1,finp:1,connect:0.000000,cps:0.000200;
id:4,confirmed:no,local_consumed_amount:0.000800,global_consumed_amount:3.126200,local_max_amount:30.000000,global_max_amount:30.000000,call_id:0f44fbc63883e52d72c9f52f49253476@185.47.15.56:5080,start_timestamp:0,inip:1,finp:1,connect:0.000000,cps:0.000800;

id 0 and id 1 are the same call that has been inserted twice.
id 2 and id 3 are the same call that has been inserted twice.
id 4 is a finished call that has not been removed from the stack and continues discounting credit.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/2383

Commit Summary

cnxcc: remove duplicated entries with a same CID value

File Changes

M src/modules/cnxcc/cnxcc_mod.c (50)

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.