Hello,
why do you complain in this case when you don't even give a chance for others to review your commits pushed to modules you haven't authored, nor you maintain?
- https://github.com/kamailio/kamailio/commit/6183319381573e42b882d05ae1748539...
So others have to do it, only you don't?
Cheers, Daniel
On 18.05.23 12:39, Henning Westerholt wrote:
Hello,
the PR related to this proposal was merged quite fast, less then 24h after creation. Why this was merged already, given that it affects all modules?
I have nothing against this change, but it would have been polite to give it a bit more time for feedback from other module authors, especially as today is a public holiday in many countries. It might also cause conflicts with other people work in progress code.
Cheers,
Henning
-----Original Message----- From: Victor Seva linuxmaniac@torreviejawireless.org Sent: Mittwoch, 17. Mai 2023 16:01 To: Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org Subject: [sr-dev] clang-format changes
Hi,
I'm thinking we should start enforcing clang-format in order to have a coherent indentation and coding style in the project.
I've added a check in the pull-request Github Action to check the clang-format in the commits but for sure now it will almost always fail due to our code is not always formatted properly.
Is is OK if I start committing changes module by module of just changes related to clang-format formatting?
I'm aware this will our life harder to backport fixes to supported branches but I think it will help us in the long run.
Cheers
| ,''`. Victor Seva | | : :' : linuxmaniac@torreviejawireless.org | | `. `' PGP Key ID: 0x51A09B18CF5A5068 | | `- Debian Developer |
Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-leave@lists.kamailio.org