Hello,

We realized that redis_execute should return a negative value in case of failure (just like redis_cmd), instead of always returning 1. This introduced a problem with the behavior when calling redis_execute without giving a server name. Since this function will loop through all the servers and execute the pipelined commands for each one, in case of failure the user cannot determine for what server the error occurred, by only returning a negative value. This is why we decided to remove the possibility to call redis_execute with no arguments, and have it loop through all defined servers. The user should only call redis_execute(srv_name) and check the return value for this.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1112

Commit Summary

• ndb_redis: remove redis_execute command with no arguments
• ndb_redis: make redis_execute() return negative value on error

File Changes

• M src/modules/ndb_redis/doc/ndb_redis_admin.xml (10)
• M src/modules/ndb_redis/ndb_redis_mod.c (22)
• M src/modules/ndb_redis/redis_client.c (20)
• M src/modules/ndb_redis/redis_client.h (1)

Patch Links:

• https://github.com/kamailio/kamailio/pull/1112.patch
• https://github.com/kamailio/kamailio/pull/1112.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.