@korayvt - a variant that keeps also the backward
compatibility is to go over the list of connections parameters and if `connect_timeout` is
missing, then add it like it is done now, when `pg_timeout>0`.
On another aspect, I would suggest to go for the style of
'param_name=param_value", it seems that the postgres param names are compatible
with sip param names, as I can see at the link you provided:
*
https://www.postgresql.org/docs/12/libpq-connect.html#LIBPQ-PARAMKEYWORDS
So instead of:
```
modparam("db_postgres", "con_param",
"name=connect_timeout;value=15")
modparam("db_postgres", "con_param",
"name=tcp_user_timeout;value=5000")
```
It can be:
```
modparam("db_postgres", "con_param", "connect_timeout=15")
modparam("db_postgres", "con_param",
"tcp_user_timeout=5000")
```
And the above can also be compacted to:
```
modparam("db_postgres", "con_param",
"connect_timeout=15;tcp_user_timeout=5000")
```
It would require some changes in function `postgres_con_param()`.
Hi Daniel,
I will consider your suggestions and make a new commit.
Thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: