[sr-dev] git:master:20634fcc: ims_qos: doc and logs update

Module: kamailio Branch: master Commit: 20634fccc59c82a35b45a3da0b8e6a0e64acb37e URL: https://github.com/kamailio/kamailio/commit/20634fccc59c82a35b45a3da0b8e6a0… Author: Stefan Mititelu &lt;stefan-cristian.mititelu(a)1and1.ro&gt; Committer: Henning Westerholt &lt;hw(a)gilawa.com&gt; Date: 2023-08-14T17:08:35+02:00 ims_qos: doc and logs update --- Modified: src/modules/ims_qos/doc/ims_qos_admin.xml Modified: src/modules/ims_qos/ims_qos_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/20634fccc59c82a35b45a3da0b8e6a0… Patch: https://github.com/kamailio/kamailio/commit/20634fccc59c82a35b45a3da0b8e6a0… --- diff --git a/src/modules/ims_qos/doc/ims_qos_admin.xml b/src/modules/ims_qos/doc/ims_qos_admin.xml index b8a36c7b136..7755a963abd 100644 --- a/src/modules/ims_qos/doc/ims_qos_admin.xml +++ b/src/modules/ims_qos/doc/ims_qos_admin.xml @@ -29,7 +29,7 @@ <itemizedlist> <listitem> - <para>Dialog</para> + <para>IMS Dialog</para> </listitem> <listitem> @@ -625,8 +625,8 @@ route[REG_AAR_REPLY] </listitem> </itemizedlist> - <para>This function can be used from REQUEST_ROUTE or - ONREPLY_ROUTE.</para> + <para>This function can be used only from ONREPLY_ROUTE, only for replies to INVITE, UPDATE, PRACK. + The reply and request must have SDP, for this function to work properly.</para> <para>p.s. this is executed asynchronously. See example on how to retrieve return value</para> diff --git a/src/modules/ims_qos/ims_qos_mod.c b/src/modules/ims_qos/ims_qos_mod.c index d2502020450..9ff174f03eb 100644 --- a/src/modules/ims_qos/ims_qos_mod.c +++ b/src/modules/ims_qos/ims_qos_mod.c @@ -205,8 +205,8 @@ static int pv_t_copy_msg(struct sip_msg *src, struct sip_msg *dst) } -static cmd_export_t cmds[] = {{"Rx_AAR", (cmd_function)w_rx_aar, 4, fixup_aar, - 0, REQUEST_ROUTE | ONREPLY_ROUTE}, +static cmd_export_t cmds[] = { + {"Rx_AAR", (cmd_function)w_rx_aar, 4, fixup_aar, 0, ONREPLY_ROUTE}, {"Rx_AAR_Register", (cmd_function)w_rx_aar_register, 2, fixup_aar_register, 0, REQUEST_ROUTE}, {0, 0, 0, 0, 0, 0}}; @@ -801,7 +801,7 @@ static int w_rx_aar( } if(t->uas.status >= 200) { - LM_DBG("transaction sent out a final response already - %d\n", + LM_WARN("transaction sent out a final response already - %d\n", t->uas.status); return result; } @@ -864,13 +864,13 @@ static int w_rx_aar( || memcmp(t->method.s, "UPDATE", 6) == 0))) { if(cscf_get_content_length(msg) == 0 || cscf_get_content_length(orig_sip_request_msg) == 0) { - LM_DBG("No SDP offer answer -> therefore we can not do Rx AAR"); + LM_WARN("No SDP offer answer -> therefore we can not do Rx AAR"); //goto aarna; //AAR na if we don't have offer/answer pair return result; } } else { - LM_DBG("Message is not response to INVITE, PRACK or UPDATE -> " - "therefore we do not Rx AAR"); + LM_WARN("Message is not response to INVITE, PRACK or UPDATE -> " + "therefore we do not Rx AAR"); return result; } @@ -1162,7 +1162,7 @@ static int w_rx_aar( int ret = create_new_callsessiondata(&callid, &ftag, &ttag, &identifier, identifier_type, &ip, ip_version, &rx_authdata_p); if(!ret) { - LM_DBG("Unable to create new media session data parcel\n"); + LM_ERR("Unable to create new media session data parcel\n"); goto error; }