11 Nov
2013
11 Nov
'13
3:48 p.m.
On 2013-10-29 at 09:34, Daniel-Constantin Mierla wrote:
Fixed in the new patch.
--
Øyvind Kolbu
On 10/18/13 3:14 PM, Øyvind Kolbu wrote:
Hi and sorry for the late reply. Been offline on vacation.
Yes, the value has to be 1 to actually ignore the rfc. The code
was correct, but the default value not. Fixed in the attached patch.
Made a core option, dns_naptr_ignore_rfc, default
off, to preserve today's
behavior.
did I get it wrong or the dns_naptr_ignore_rfc has to be 1 (on) to
preserve current behaviour? You said 'off' (expect 0) which collides
with the 'ignore' in the name of the parameter. One
implementation detail is that one currently can disable a protocol
by setting the priority to -1. In my patch that is currently ignored.
Can add a check for that in init_naptr_proto_prefs() before setting
a protocol's preference to 1.
Can you add the check for ignoring a protocol? Sometime it might be
needed. Resend the patch and I will push it to repo.