26 Aug
2022
26 Aug
'22
10:46 a.m.
It seems the needed PR in libstirshaken was merged pretty quickly:
- https://github.com/signalwire/libstirshaken/pull/123
Not sure about other things that need to be clarified for this PR to be merged.
I see that @piotrgregor is also willing to go with a forked repository of libstirshaken
that he wants to maintain at a faster pace. As I am using Kamailio with secsipid module
for STIR/SHAKEN, thus not really impacted by any change to stirshaken module, I feel it
can bring confusion and conflicts over the time if both `libstirshaken` (the original and
the fork) are developed further and diverge. Usually people tend to go to the original
project or have that lib also installed because of other dependencies.
For example, the original libstirshaken is used by FreeSwitch, which will be installed as
a deb/rpm dependency. Then we can't get Kamailio installed on the same system having a
dependency with same name but from another repo. I faced something similar as FreeSwitch
forked (and diverged) libspandsp (iirc), which conflicts with the original one that is
needed by RTPEngine.
IMO, a fork of a repository should retain the name if wants to contribute back to the
original. If wants to diverge in development and offer another viable alternative, it
should be renamed to something else to avoid conflicts like I exemplified above.
Again, with not much personal interest in this module, it is probably better that
@piotrgregor renames its repo then also "forks" the Kamailio module to another
one using the new name, then works on it. That adds some overhead, but we have many other
modules for similar purpose (e.g., lcr, drouting) and over the time maybe it becomes clear
which one to keep or remove (like it happened with jabber vs xmpp module).
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3175#issuecomment-1228167237
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3175/c1228167237(a)github.com>