@miconda commented on this pull request.


In src/modules/http_client/curlcon.c:

> @@ -854,3 +854,24 @@ curl_con_t *curl_init_con(str *name)
 	LM_DBG("CURL: Added connection [%.*s]\n", name->len, name->s);
 	return cc;
 }
+
+/*! Fixup CURL connections - if timeout is not configured, Use as default global connection_timeout.
+ */
+void curl_conn_list_fixup(void)
+{
+	curl_con_t *cc;
+	cc = _curl_con_root;
+	while (cc) {
+		if (!(timeout_mode == 1 || timeout_mode == 2)) {
+			/* Timeout is disabled globally. Set timeout to 0 for all connections to reflect this. */
+			cc->timeout = 0;

I would add a warning log message if cc->timeout > 0 before setting it to 0, to make the config admin properly aware of the situation.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/3615/review/1695234317@github.com>