Re: [sr-dev] git:master: modules_k/nathelper: Add is_rfc1918(ip_addr) function to test ip_addr for rfc1918addresses.

On Friday 29 July 2011, Iñaki Baz Castillo wrote:

...

Indeed there is kind of "conflict of interests" here. Maybe the ipops can get a slightly different implementation, where the match can be, based on parameters, restricted to a network address match. I thought would be useful in non-nat-travesal cases, where nathelper is not loaded.

I've already implemented it in ipops module. The function (not commited yet) is called "ip_is_rfc1918()" not to conflict with "is_rfc1918()" function in nathelper module (I'd really would like *namespaces* for separating module functions!) :)

Is it ok if I commit it?

Hi Iñaki,

i saw that you just commited it. Does the new function does implement the same functionality as the one in nathelper?

Best regards,

Henning