[sr-dev] Re: [kamailio/kamailio] ims_isc: bugfix: firstflag incorrect in isc_match_filter (PR #4018)

@vingarzan commented on this pull request. int free_s = 0; //the callback from the Cx interface in case of unreg terminating initial message is a FAILURE_ROUTE. Hence we need an addl. flag + // meaning of firstflag: + // firstflag == 0: + // request route: request has been received from AS, old ISCMARK found in Route header field + // failure route: request to AS has been rejected or timed out, old ISCMARK found in lumps Does it makes sense to have 4 possible values instead of just 2? Is that even possible though? I'm thinking if that would make things more clear, instead of having to remember that each of the current values have 2 sub-cases. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4018#pullrequestreview-2445078234 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4018/review/2445078234(a)github.com>