Hi, thank you for the feedback!

Yes, I was also thinking about that double lock_get()/release(). Actually in my tests I updated the code to be under a single lock_get()/release(), kept shm alloc outside the locks and shm released it when/if necessary inside lock_get()/release().

Since this new addmodes might have valid use cases in some scenarios, I will update the PR soon. In the short time frame, got no intention to update the code to using hash table, but maybe in the longer time frame will do it.

Thank you,
Stefan


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/3053/c1077749584@github.com>