Re: [sr-dev] [kamailio/kamailio] Unexpected kamailio 5.4 segfault related to dialog variables (#2828)

I haven't implemented the dialog variables, nor use them in my deployments, but given several reports with issues related to them, I looked once quickly over them and I think they are exposed to races. I made a similar remark to a recent PR that was using dialog variables, Unfortunately I had no time to dig in further, too many constraints with work and family due to pandemic and no deployment that reproduces similar crashes (again, I don't use dialog variables). Near future does not look better in terms of available time. If you or someone else can do it, review the code related to dialog variables. I think getting a variable just references to the share memory location, without any other protection (or cloning). Alternative, for a while, is to see if you can replace dialog variables with something else, maybe you can use htable, and same same results. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2828#issuecomment-1162979167 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/2828/1162979167(a)github.com>