Re: [sr-dev] [kamailio/kamailio] tls: add support for OpenSSL engine and private keys in HSM (#1484)

Hello, thank you for the contribution! A few observations/questions from my side: * you added the new functionality as a pre-processor define, what was the reason for this? Will this change break some other functionality, or is there some other compatibility issue/new dependencies introduced? Otherwise I would suggest to make it configurable during run time. * you have added a fair number of white space changes, was this caused from a automated code formatting or something similar? * you added a configuration snipped to the code, this should be also moved to the module README or another file (but its OK to do it later as normal docs are also missing, as you mentioned) Lets work on this first and then have a closer look to the code. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1484#issuecomment-374388863