17 Aug
2021
17 Aug
'21
12:04 a.m.
Thanks for the pull request. Just a few notes, other
might be able to comment more:
* instead of extending the core and adding another command line parameter for it, I
think it should be implemented as a extension module, similar e.g. to log_systemd module
This can make it more difficult to log unusual things during the startup phase before the
modules are loaded.
There is already JSON support in core so I feel there is a good reason to keep the JSON
code together in the same place. The ```log_systemd``` code is much more different.
There is also a possibility that this code could replace the existing JSON code. That
would be easier to maintain but it would break compatibility for anybody who already
depends on the old JSON schema.
* the code includes pthread.h and also calls pthread_self(), this should be not
necessary as there is no pthread_create() in the core right now (Kamailio uses mainly the
multi-process model)
If any of the extension modules or libraries start threads then it is useful to capture
the thread ID. However, the field is optional, it can be completely removed and the rest
of the pull request would still be valid without this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2826#issuecomment-899817075