On May 11, 2009 at 10:59, Jan Janak jan@iptel.org wrote:
On 10-05 10:15, Andrei Pelinescu-Onciul wrote:
On May 09, 2009 at 18:15, Juha Heinanen jh@tutpro.com wrote:
Module: sip-router Branch: master Commit: a3f16850cd2a897710cb0a56174e9f64dcc77653 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a3f16850...
Author: Juha Heinanen jh@tutpro.com Committer: Juha Heinanen jh@tutpro.com Date: Sat May 9 19:14:18 2009 +0300
- Moved lcr module from modules_k to modules and removed it from modules_s.
They should have been merged. Looking only at recent commit logs, you lost from modules_s/lcr:
- rpc interface
That's not necessary, the rcp interface was only used to reload the data from the database and kamailio version has this too.
From my point of view it is. It's lost functionality when going from ser
version to k version.
- new db api
Not necessary either, it can work with the old db interface, in case of lcr it does not matter whether we use prepared statements or not because the module works primarily with the memory cache.
But isn't it a step backwards? At some point in the future we'll obsolete anyway the old db.
- possible wrong db init from all the processes (see 8fb14f, 9961e8)
That's the only thing, imho, that needs to be changed.
Andrei