Re: [sr-dev] sip_trace() broken in master

Actually, if you set the tracing mode and also the flag, you will get duplicated packets! I lived through that a few days ago :) On Mon, 30 Sep 2019 at 19:22, Daniel-Constantin Mierla &lt;miconda(a)gmail.com <mailto:miconda@gmail.com>> wrote: Can you try with latest master? I pushed a commit that hopefully fixes it. On the other hand, the use of flag looks like no longer necessary if tracing mode parameter is set to 't'. Would it be acceptable to just add a new function sip_trace_mode() that will accept one parameter to specify what to track (message, transaction, dialog)? It would be a short form of sip_trace() with 3 parameters, when the two are not needed. I think it would be more coherent for the future to get rid of using also the message flag for tracking the transaction. Cheers, Daniel On 30.09.19 18:00, Juha Heinanen wrote: -- Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com> www.twitter.com/miconda <http://www.twitter.com/miconda> -- www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda> Kamailio Advanced Training, Oct 21-23, 2019, Berlin, Germany -- https://asipto.com/u/kat _______________________________________________ Kamailio (SER) - Development Mailing List sr-dev(a)lists.kamailio.org <mailto:sr-dev@lists.kamailio.org> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev -- Regards, David Villasmil email: david.villasmil.work(a)gmail.com <mailto:david.villasmil.work@gmail.com> phone: +34669448337