Camille, thanks for the feedback.  Those are great points, and I'll try to complete work on those configuration features soon.

On Mon, Jan 4, 2016 at 5:33 AM, Camille Oudot <notifications@github.com> wrote:

Hi Armen,
thanks for your patch, I think this feature will be very useful.
I have one comment: if the tcpops module is loaded but no tcp:closed route is defined, a debug log line will complain about it. I think it would make sense to add a module parameter to globally enable or disable the event route lookup and execution.
Besides, as many of the tcpops function can act on a per-socket basis, it would be nice to have this event route called or not called depending on the socket (e.g. using a tcp_connection flag and defining a new tcpops function to set/reset this flag).
What do you think?


Reply to this email directly or view it on GitHub.


_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev