25 Feb
2019
25 Feb
'19
2:09 p.m.
Hello Henning,
In regards of first comment, This module is developed to provide handover
interface for lawful Interception in IMS-Network(VoIP-Services) for
Kamailio. Actually I am developing,yet, just as like some optimization
code, add extra features and more. My implementation is based on ETSI
TS133.108 and TS133.107. In this case Kamailio works just as LIG (Lawful
Interception Gateway) in VoIP network and getting all data (signalling)
from network and send them for LEA in specific (TLV) template.
Along with of second comment, yes, of course. We could talk more about it
after developing finished.
As well as of third comment, i have never pushed cmake file before, It is
my GUI (CLION GUI) for programming in C that i am working on with.
And fourth comment, i deleted htable commit from here and make new pull
request.
With Best Regards. Mojtaba
On Mon, Feb 25, 2019 at 1:49 PM Henning Westerholt <notifications(a)github.com>
wrote:
Thank you for the your interest in Kamailio and the
module in development.
I did a quick high level look today and have a few comments:
- can you give a small description what your module actually does? :-)
- a huge part of your code is related to the asn1 functionality. Some
of this is library code that could be maybe placed elsewhere, some of them
is generated from a ASN1 definition. If you finished the development we
should discuss how to deal with this. Maybe something can be also just add
as a build dependency and don't need to be included.
- there is a cmake file inside, do you use cmake for something? In
Kamailio we use standard make for building
- you just pushed a change to the htable module, this should be a
separate pull request as its isolated from your module
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/kamailio/kamailio/pull/1856#issuecomment-466956126>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ArE2rHQoyy1mbCV-B-ZItjank6pBnl0Rks5vQ7jLgaJpZM4a-_NY>
.
--
--Mojtaba Esfandiari.S
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1856#issuecomment-466971511