This commit

• removes the python calls whose output is never actually used.

• changes the include discovery to use python3(.x)-config. This is
  preferable because it also works for cross-compiling. Calling
  python3(.x) directly will always provide host flags, which for
  cross-compiling is not feasible.

• updates LDFLAGS discovery to also work with >= Python 3.8. To
  achieve this python3(.x)-config is first run with the argument
  "--embed". If this does not succeed (exit status 1)
  python3(.x)-config is run again without "--embed". This is the
  method suggested by Python upstream to provide backwards
  compatibility. See [1] for more details.

[1] https://docs.python.org/3/whatsnew/3.8.html

Signed-off-by: Sebastian Kemper sebastian_ml@gmx.net

Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue #XXXX (replace XXXX with an open issue number)

Description

Hi all,

While trying to get app_python3 going on OpenWrt I stumbled over this. We're cross-compiling and I got the wrong includes (host includes instead of target includes).

And then there was also the "-lpython3.x" missing because we're using python 3.8 which doesn't provide this linker flags by default anymore. So once I tried to load the module on the target device it threw an error:

Fri Apr 10 18:52:13 2020 daemon.err kamailio[15622]:  0(15622) ERROR: <core> [core/sr_module.c:512]: load_module(): could not open module </usr/lib/kamailio/modules/app_python3.so>: Error relocating /usr/lib/kamailio/modules/app_python3.so: PyTuple_New: symbol not found
Fri Apr 10 18:52:13 2020 daemon.err kamailio[15622]:  0(15622) CRITICAL: <core> [core/cfg.y:3543]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 124, column 12-27: failed to load module

This pull requested fixes this.

Kind regards,
Seb

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2282

Commit Summary

• app_python3: update Python3 detection mechanism

File Changes

• M src/modules/app_python3/Makefile (12)

Patch Links:

• https://github.com/kamailio/kamailio/pull/2282.patch
• https://github.com/kamailio/kamailio/pull/2282.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.