You're right. Maybe adding also the check on the received address? I didn't want to have a too heavy logic there, but it could make sense.

On Fri, Jul 8, 2016 at 10:15 AM, Daniel-Constantin Mierla <notifications@github.com> wrote:

You can merge it.

I think it covers the most of the cases, but some corner ones may not be covered. Like one behind a nat router that is changing the public ip -- so the contact is the same, but the received address (computed from source ip) will be different. I guess this can happen only if the phone did a re-register at the time was called and the router changed its up more or less at that moment.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev