24 Nov
2008
24 Nov
'08
11:52 a.m.
On Friday 21 November 2008, Andrei Pelinescu-Onciul wrote:
I agree that we need to rename the identifiers, but it is really necessary to
rename the macros also? Do we plan to compile a module with both DB APIs at
the same time?
Cheers,
Henning
On Nov 21, 2008 at 04:34, Jan Janak
<jan(a)iptel.org> wrote:
[...]
Hi Andrei,
if you can keep the history this would be nice, but we can also use Jans
version directly. For the naming, libsrdb1 and libsrdb2 is ok.
Unless nobody objects, I would suggest we do
the following:
1) Convert both API versions into libraries. Here I would suggest some
simpler name, sr_dbk sounds is cryptic, how about using just db1 and
db2 possibly prefixed with sr (libsrdb1, libsrdb2)?
Do we go for libsrdb[12] or somebody has a better ideea?
Do I keep the kamailio db history or we use directly Jan's version (no
history)? 2) Rename
conflicting identifiers in both libraries, i.e. db_con1,
db_con2, db_res1, db_res2.
I think we would have to rename the DB_* macros too:
DB1_STR DB1_INT DB1_BLOB DB1_BIGINT DB1_DOUBLE DB1_STRING DB1_DATETIME
DB1_BITMAP