<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> Some improvements related to DMQ node status: 1. Allow other modules that use DMQ to detect NOT_ACTIVE nodes via default response callback. Note that only internal dmq ping mechanism can set them back to DMQ_NODE_ACTIVE status. 2. Simplify node status and merge DMQ_NODE_PENDING + DMQ_NODE_TIMEOUT into DMQ_NODE_NOT_ACTIVE since those specific states were never used to be compared against. 3. Add new mod parameters which will control after how many fails the node should be moved to DMQ_NODE_NOT_ACTIVE state.
Under testing currently. Will update if any bugs found. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4182
-- Commit Summary --
* dmq: add default response callback * dmq: simplify node status * dmq: add two new modparams
-- File Changes --
M src/modules/dialog/dlg_dmq.c (16) M src/modules/dialog/dlg_dmq.h (3) M src/modules/dmq/dmq.c (4) M src/modules/dmq/dmq.h (2) M src/modules/dmq/dmq_funcs.c (6) M src/modules/dmq/dmqnode.c (70) M src/modules/dmq/dmqnode.h (9) M src/modules/dmq/doc/dmq_admin.xml (64) M src/modules/dmq/notification_peer.c (80) M src/modules/dmq/notification_peer.h (3) M src/modules/dmq_usrloc/usrloc_sync.c (12) M src/modules/dmq_usrloc/usrloc_sync.h (2) M src/modules/htable/ht_dmq.c (15) M src/modules/htable/ht_dmq.h (3) M src/modules/presence/presence_dmq.c (16) M src/modules/presence/presence_dmq.h (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4182.patch https://github.com/kamailio/kamailio/pull/4182.diff