28 Apr
2022
28 Apr
'22
3:16 p.m.
@miconda commented on this pull request.
if (result == NULL || t == NULL)
{
PKG_MEM_ERROR;
goto clean;
}
- snprintf(result, elements->len - toRemove->len, "%*s", elements->len
- toRemove->len, "");
- snprintf(t, elements->len+1, "%s", elements->s);
+ memset(result, 32, elements->len - toRemove->len);
What is the purpose of filling `result` buffer with space (char code `32`)?
}
}
if (elements->len-toRemove->len > 0)
{
- snprintf(elements->s, elements->len, "%*s",
elements->len-toRemove->len, "");
+ memset(elements->s, 32, elements->len - toRemove->len);
snprintf(elements->s, (strlen(result)%elements->len)+1, "%s", result);
Another `memset` with char code 32 (space), then `snprintf` in the same buffer.
Maybe it is ok, but `memset` with `space` is quite unusual, therefore asking for further
details.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3095#pullrequestreview-956330819
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3095/review/956330819(a)github.com>