Hello,<br>
Yes, Tell me about it.<br>
I will do it as soon as.<br>
I am far away right now. Actually i am going to Germany embassy.<br>
<br>
On Wed, 20 Feb 2019, 14:15 Daniel-Constantin Mierla, &lt;<br>
notifications@github.com&gt; wrote:<br>
<br>
&gt; There is no code for your module, it seems you try to add it as a git<br>
&gt; submodule. It has to be pushed with full code, if you want it to merge it<br>
&gt; inside kamailio repository.<br>
&gt;<br>
&gt; Then your commit messages do not follow the contributing guidelines:<br>
&gt;<br>
&gt;    -<br>
&gt;    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format<br>
&gt;<br>
&gt; I also suggest that you put the function you added in core to your module,<br>
&gt; it seems to target usage only there and there is no reason it doesn&#39;t work<br>
&gt; having it inside your module. If it needs to be used in other modules<br>
&gt; later, it can be relocated.<br>
&gt;<br>
&gt; —<br>
&gt; You are receiving this because you are subscribed to this thread.<br>
&gt; Reply to this email directly, view it on GitHub<br>
&gt; &lt;https://github.com/kamailio/kamailio/pull/1856#issuecomment-465522509&gt;,<br>
&gt; or mute the thread<br>
&gt; &lt;https://github.com/notifications/unsubscribe-auth/ArE2rGb76fmIyAZqmVh6E3u57X8b4_nAks5vPScsgaJpZM4a-_NY&gt;<br>
&gt; .<br>
&gt;<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1856#issuecomment-465525720">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZY0KLLQBG5ClF9YrNswymKnu1YNvks5vPSlkgaJpZM4a-_NY">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZfQXSzG6RodAn765eD2AHlCijgjOks5vPSlkgaJpZM4a-_NY.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mojtabaesfandiari in #1856: Hello,\nYes, Tell me about it.\nI will do it as soon as.\nI am far away right now. Actually i am going to Germany embassy.\n\nOn Wed, 20 Feb 2019, 14:15 Daniel-Constantin Mierla, \u003c\nnotifications@github.com\u003e wrote:\n\n\u003e There is no code for your module, it seems you try to add it as a git\n\u003e submodule. It has to be pushed with full code, if you want it to merge it\n\u003e inside kamailio repository.\n\u003e\n\u003e Then your commit messages do not follow the contributing guidelines:\n\u003e\n\u003e    -\n\u003e    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format\n\u003e\n\u003e I also suggest that you put the function you added in core to your module,\n\u003e it seems to target usage only there and there is no reason it doesn't work\n\u003e having it inside your module. If it needs to be used in other modules\n\u003e later, it can be relocated.\n\u003e\n\u003e —\n\u003e You are receiving this because you are subscribed to this thread.\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps://github.com/kamailio/kamailio/pull/1856#issuecomment-465522509\u003e,\n\u003e or mute the thread\n\u003e \u003chttps://github.com/notifications/unsubscribe-auth/ArE2rGb76fmIyAZqmVh6E3u57X8b4_nAks5vPScsgaJpZM4a-_NY\u003e\n\u003e .\n\u003e\n"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1856#issuecomment-465525720"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1856#issuecomment-465525720",
"url": "https://github.com/kamailio/kamailio/pull/1856#issuecomment-465525720",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>