Re: [sr-dev] [kamailio/kamailio] siptrace: siptrace: fix memory leak in fake replies tracing (#2295)

22 Apr 2020


      @grumvalski commented on this pull request.
...
@@ -1607,6 +1608,11 @@ static void trace_onreply_out(struct cell *t, int type, struct tmcb_params *ps)
if(msg == NULL || msg == FAKED_REPLY) {
    	msg = t->uas.request;
    	faked = 1;
+		/* check if from header has been already parsed.
+		 * If not we have to parse it in pkg memory and free iit at the end.
+		 */
+		if (msg->from && msg->from->parsed != NULL)
you're right, I wrongly copied from local. I'm going to fix and force push.
-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2295#discussion_r412797476



    