On Sun, Oct 18, 2009 at 12:09 PM, Juha Heinanen jh@tutpro.com wrote:
[...]
by the way, this encoding/decoding business in the code is ugly. if i remember correctly, AVPs can now have also structure values. if so, encoding/decoding could be avoided.
Yes, there is certainly space for improvements. We could also improve the way how the serial forking code handles timers. Instead of configuring a static value with fr_inv_timer_next, we could compute the value of fr_inv_timer_next dynamically, based on the number of serial branches in the destination set and the value of max_inv_lifetime timer. Alternatively, we could also increase the value of max_inv_lifetime if serial forking is used in a transaction. The value of that timer is stored in the transaction, so it can be done selectively only for certain transactions. There are many possibilities how we can adjust timers automatically for serial forking...
-- Jan