Re: [sr-dev] [Redis module] Kamailio crashes in case of connection lost to redis server

Hello Vicente, Thank you for your reply, you'll find my answer below On Thu, Nov 28, 2013 at 12:03 AM, Vicente Hernando &lt;vhernando(a)systemonenoc.com <mailto:vhernando@systemonenoc.com>> wrote: Hello, also full steps to crash kamailio and reproduce the error would be good. Here is the architecture A <--> Asterisk <--> Kamailio 1 <---> kamailio2 <--- ISP---> mobile Kamailio 1 & 2 are connected to a local redis server 1/ I restarted the redis server 2/ From the mobile I made a call to A then cancelled it. In the script of kamailio1, if a call has missed or failed, it sends a message to the redis. And in this case, it crashes On 11/27/2013 11:35 PM, Daniel-Constantin Mierla wrote: I assume you disconnect redis server and don't reconnect it. It is that correct? Then this line is an error but it should recover from that. I probably should set this as a warning instead an error. /usr/local/sbin/kamailio[25333]: ERROR: ndb_redis [redis_client.c:364]: redisc_exec(): Redis error: Server closed the connection Yes, it has been restarted In the source code: rpl->rplRedis = redisvCommand(rsrv->ctxRedis, cmd->s, ap ); if(rpl->rplRedis == NULL) { /* null reply, reconnect and try again */ if(rsrv->ctxRedis->err) { LM_ERR("Redis error: %s\n", rsrv->ctxRedis->errstr); } if(redisc_reconnect_server(rsrv)==0) { rpl->rplRedis = redisvCommand(rsrv->ctxRedis, cmd->s, ap); } } First redisvCommand executes but returns nothing. Then it shows a redis error. It tries to reconnect and it manages to connect ?? because it shows no more errors. And then executes redisvCommand again and crashes. If server is down it should not be able to connect and so not to execute redisvCommand again. According to the core, we MUST be in this case *if(redisc_reconnect_server(rsrv)==0) * But I am wondering how the first redisvCommand can succeed before the reconnection ? (the connection kamailio1 <-> redis has already been taken down). Does all the redis context always there when we first call redisvCommand? May be I would get more clues with more information. Regards, Vicente. Thank you Regards,