It might add more complexity to try to work on the same variable, as I quickly looked over the commit of the PR, one field is inside a cfg-param reload structure, which is trickier to figure out if it was set because of a modparam or because of a rpc command and then know which parameter name was used to set it. I think it will bring more overhead in code maintenance than two variables (or two fields in the cfg-param reload structure).

If two variables/fields is considered overhead, I would rather suggest to remove the old second-based timeout completely and add the new one with a different name, so on upgrading to the next release, the config has to be updated as well.

Regarding the RPC commands, I see only "httpclient.listcon" for this module.
I don't think the module can be reconfigured through RPC, or am I missing something ?


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/3609/c1773081226@github.com>