Description

SIP OPTION relayed using t_forward_nonack() not being URI decoded

Troubleshooting

Reproduction

register with PATH and use SIP OPTION keep alive
or simply send relay a SIP OPTIONS with a route.

Debugging Data

    p_msg=0x7fa3885aa1c0, proxy=0x0, proto=0) at t_fwd.c:1729
1729				raise(SIGSEGV);
(gdb) l
1724				ser_error=MIN_int(lowest_ret, E_CFG);
1725				return -1;
1726			}
1727			if(lowest_ret!=E_CFG) {
1728				LM_ERR("failure to add branches\n");
1729				raise(SIGSEGV);  << raising exception to get the coredump
1730			}
1731			ser_error=lowest_ret;
1732			return lowest_ret;
1733		}

Log Messages

4(34) ERROR: tm [ut.h:245]: uri2dst2(): bad_uri: sip:247.25.169.51:52307%3Btransport%3Dtls
4(34) ERROR: tm [t_fwd.c:1728]: t_forward_nonack(): failure to add branches

Possible Solutions

This patch can fix the problem from the routing script :

if (is_method("OPTIONS") && uri!=myself) {
        $var(path_uri) = $(hdr(Route){re.subst,/<(.*)>/\1/});                                                                                                                                                       
        if (defined $(var(path_uri){uri.params}) && $(var(path_uri){uri.params}{param.value,received})         != "") {
                $var(received) = $(var(path_uri){uri.params}{param.value,received});
                if ($var(received) =~ "sip:.*:.*") {
                        $du = $var(received);           
                $avp(received) = $(var(path_uri){uri.params}{param.value,received});
                avp_subst("$avp(received)", "/%3Btransport%3Dtcp/;transport=tcp/ig");
                if ($avp(received) =~ "sip:.*:.*") {
                        $du = $avp(received);           
                }
        }
        t_relay();
}

Additional Information

tested on 5.3.2, something changed during 5.3.0.dev, I will try to pin point the commit

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.