In my opinion, consider the considerations of strong
module dependencies in the design. For example, you have used the capabilities of another
module in your code and called it recently, while it might be better to design and
implement this capability in the new module itself. Another important point is that this
heavy dependency can even reduce the performance of the Rrtpengine module in normal mode.
Suppose you have several rtpengine nodes separately from the Kamailio server. In this
case, you will not receive the media packets on the Kamailio server itself. How does the
new module want to access the packets on the other server? I think each nodes separately
performs the recording operation and saves it to its own file system. However, this
development can be a good contributions for Kamailio.
Thank you for the feedback. I agree with @henningw, to address your concerns:
1) Re-implementing rtpengine functionality in the new module would result in redundant
code, which isn't ideal. Leveraging existing modules promotes maintainability.
2) Similar approaches, like SIPREC in OpenSIPS, use existing RTP related modules
effectively.
3) Regarding performance concerns, the module assumes recording is handled by each node
individually, minimizing any impact on Kamailio.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3948#issuecomment-2295269544
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3948/c2295269544(a)github.com>