Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: fixed warnings, added a new config param (#2148)

Hello, thanks for the pull request. Please separate the bugfixes (that needs to be backported) from functional additions next time. I assume that the bugfix is in spi_gen.c and also one related to the log in int add_supported_secagree_header(struct sip_msg* m) . After merging I can manually backport. About the functional change: * in ipsec_forward() add supported and require secagree headers only for Register reply with code 200. Set SND_F_FORCE_SOCKET for request messages. Two questions: - Was the previous behaviour to apply it for all SIP methods wrong? - Are there cases where one does not want to force the send socket for the messages? I am just trying to sort out if the change might break other people configs and some parameter needs to be added. I have one general remark related to the locking in the module. It uses directly the pthread function calls. Usually all modules should use the kamailio locking interface (in core/locking.h). The simple lock is probably ok for this module. Would be great if you could convert it to this in one of your next changes. You can look to e.g. to the ims_usrloc* modules to have a look to the implementation. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2148#issuecomment-558286133