Looks fine to me, you can merge.
Just a note for the archive - would probably make sense to review static int
handle_ruri_alias(struct sip_msg *msg) in nathelper.c, which does a kind of similar
function internally like the new added extract_alias_ip_port, to see if this could be
generalized and maybe added to the core.
Hi, I will check this function handle_ruri_alias to see if it the same functionality as
the new one extract_alias_ip_port. And the idea for generalization and added the core is
good.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2246#issuecomment-610770092