Description

on busy servers, there's a sporadic crash in slow timer.
we don't have any debugging data anymore nor a way to reliably reproduce it.
just posting here in case someone sees the same and can find a way to reliably reproduce it and maybe test the patch below.

Troubleshooting

Reproduction

Possible Solutions

with the patch below we don't see any crashes
either tl or tl->f is null when it crashes. this is probably some race condition

diff --git a/src/core/timer.c b/src/core/timer.c
index 0e0dc8812..3c59db3da 100644
--- a/src/core/timer.c
+++ b/src/core/timer.c
@@ -1128,7 +1128,7 @@ void slow_timer_main()
 #endif
 				SET_RUNNING_SLOW(tl);
 				UNLOCK_SLOW_TIMER_LIST();
-					ret=tl->f(*ticks, tl, tl->data);
+					ret= (tl->f ? tl->f(*ticks, tl, tl->data) : 0);
 					/* reset the configuration group handles */
 					cfg_reset_all();
 					if (ret==0){

Additional Information

5.1 / 5.2
CentOS7


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.