I had some needs to fetch user attributes after authentication fails, after an incorrect password or expired nonce (practically for a valid user) where I used sql_query().

So its fine to add this feature from my point of view, it is saving an extra sql query. Just make a modparam to control the behaviour.

Cheers,
Daniel

*when the user failed to authenticate

On 06.03.2020 12:41, Stefan Mititelu wrote:

Hi,

I want to ask you if it would make sense for kamailio upstream code to generate_avps() (got from the database) also when the user failed to register?

Please have a look in src/modules/auth_db/authorize.c line 303.

If it makes sense, I'll do a pull request for it.

Thank you,

Stefan

_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - March 9-11, 2020, Berlin - www.asipto.com
Kamailio World Conference - April 27-29, 2020, in Berlin -- www.kamailioworld.com