Hello,

I just pushed a different patch trying to fix the issue -- yours would be good only fir xhttp_reply() function. Can you fetch again the latest master branch and report if now works ok?

Cheers,
Daniel


On 18.07.17 14:45, Dario Bozzali wrote:

Hello,

I’m quite new to Kamailio and I’m making some tests using devel release (git head).

 

I’m facing an issue in xhttp_mod module after I updated my repository to master head and in particular after  commit dc0765c04c3cb5d8981551e3f28ee6871fc803ff (14/07/2017).

In src/core/route.h line 57

#define EVENT_ROUTE   REQUEST_ROUTE

has been changed to

#define EVENT_ROUTE   (1 << 9)

 

After this change, xhttp_reply is no more accepted as valid command in event_route[xhttp:request] route in my kamailio.cfg file.

 

I suppose that the issue is caused by REQUEST_ROUTE in src/modules/xhttp/xhttp_mod.c line 74. I think it should be EVENT_ROUTE

static cmd_export_t cmds[] = {

               {"xhttp_reply",    (cmd_function)w_xhttp_send_reply,

                              4, fixup_xhttp_reply,  0, REQUEST_ROUTE},    ==========> should be (?)  4, fixup_xhttp_reply,  0, EVENT_ROUTE},

               {"bind_xhttp",     (cmd_function)bind_xhttp,

                              0, 0, 0, ANY_ROUTE},

               {0, 0, 0, 0, 0}

};

 

I changed REQUEST_ROUTE to EVENT_ROUTE and, after that, kamailio.cfg is loaded without error. I don’t know Kamailio code, so I don’t know if this change is enough.

 

Thank you and best regards,

Dario

 

 

 

 



_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - www.asipto.com
Kamailio World Conference - www.kamailioworld.com