7 Nov
2019
7 Nov
'19
6:44 p.m.
Thank you for the pull request. I looked into the
existing code of the function create_ipsec_tunnel(..)
Are you sure that the "return 0" in the error cases is correct? Should it not
be -1, as in the one case in the bottom of the function? If yes - then it makes probably
sense to combine them all into one "goto error" case.
Hi,
I am pretty sure that all return codes in error cases should be changed to -1. I am
working on this module actively and return code 0 in these error cases will cause problems
for sure.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2114#issuecomment-551136000