Re: [sr-dev] [kamailio/kamailio] nathelper: don't fail if 'a=rtcp' has no IP (#2769)

It seems to be a conflict looking at the commits in the two PRs, if the offsets are not messing my evaluation -- yours is changing replace_sdp_ip() function with: ``` - if(!hasreplaced) { + if(!hasreplaced && memcmp("a=rtcp", line, 6) != 0) { LM_ERR("can't extract '%s' IP from the SDP\n", line); return -1; } ``` The #2737 removes there: ``` - if(!hasreplaced) { - LM_ERR("can't extract '%s' IP from the SDP\n", line); - return -1; - } ``` Maybe @dwagin can check this PR as well. It has to be decided if they need to be combined or one skipped, ... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2769#issuecomment-857614445