Re: [sr-dev] [kamailio/kamailio] pua_dialoginfo: Determine dialog event types in mod_init (PR #3079)

@henningw commented on this pull request. I was probably not clear in my previous comment. I have added it to the appropriate places in your patch, maybe its more clear this way. - LM_ERR("cannot register callback for interesting dialog types\n"); - free_dlginfo_cell(dlginfo); - return NULL; - } - } else { - if (dlg_api.register_dlgcb(dlg, - DLGCB_FAILED| DLGCB_CONFIRMED_NA | DLGCB_TERMINATED - | DLGCB_EXPIRED | DLGCB_EARLY, - __dialog_sendpublish, dlginfo, free_dlginfo_cell) != 0) { - LM_ERR("cannot register callback for interesting dialog types\n"); - free_dlginfo_cell(dlginfo); - return NULL; - } - } + if (dlg_api.register_dlgcb(dlg, dialog_event_types, This will allocate new memory and copy the call back types to the new allocated structure. LM_DBG("configured to use headers for uri values\n"); } + if(publish_dialog_req_within) + dialog_event_types |= DLGCB_REQ_WITHIN; This will change the callback types, it will be not synchronized with the structure inside the dialog module. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3079#pullrequestreview-951799464 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3079/review/951799464(a)github.com>