@tsearle commented on this pull request.


In src/modules/rtpengine/rtpengine.c:

> +				} else if(str_eq(&key, "all")) {
+					ng_flags->all_legs = 1;
+				} else

I was hoping so too,
unknown flags get put into ng_flags->flags

however
https://github.com/kamailio/kamailio/blob/7de2b9b7625d9cb856944627a3a5d7c167006dc6/src/modules/rtpengine/rtpengine.c#L3594

ignores ng_flags->flags when doing the encoding. I was not brave enough to change this behaviour as the effect would be quite global!


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/4274/review/2904765554@github.com>