This is a bug fix. In NOTIFY message from S-CSCF to UE, Message Body contains different xml parameters and one of them can be a contact parameter with list of unknown-params. In some cases unknown-param has value with '%' inside. For instance: "urn%3Aurn-7%3A3gpp-service.ims.icsi.me". In this case, before the fix, adding of reginfo version breaks the string of unknown-param like this: "urn0X0P+0urn-70X0P+03gpp-service.ims.icsi.me". Adding reginfo version before contact parameters keeps unknown-param string unchanged.
On Mon, 20 May 2019 at 22:07, Henning Westerholt notifications@github.com wrote:
Thank you for the pull-request. Can you explain a bit the motivation for the change, is it just a refactoring or does it fix a bug?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kamailio/kamailio/pull/1961?email_source=notifications&email_token=ALKTZB6MUBLSU5AZ5LNVEJTPWLZFPA5CNFSM4HN72SCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVZZCJQ#issuecomment-494113062, or mute the thread https://github.com/notifications/unsubscribe-auth/ALKTZB72LCC24KBZUOSYWBTPWLZFPANCNFSM4HN72SCA .