Re: [sr-dev] [kamailio/kamailio] General improvements to imc module (#1869)

Thanks! I applied you commits manually with `git am ...` after editing the first line of each commit message to follow the contributing guidelines: * https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#co… Respectively, I added the `imc: ` prefix there. We use git log to generate the changelog for each release and it is useful to spot quickly which component was affected by that commit. Another remark for the future: you do not need to generate the README locally and then create a commit for it. You can generate it locally to check if all is ok with the docbook syntax, but then you can delete the file and do git checkout path/to/the/README. This is because we generate the readme files for modules via a cron.d job on kamailio server in order to have coherent format of the output. In the past, a small change to the docbook file could end up in a completely different style of whitespacing in the README, depending on the system where the README was generated. Last, you have git write privileges, so you can push commits directly without making pull requests. If you want someone to review the patches, then of course you can do pull requests (btw, I haven't really reviewd the code of your commits in this pull request at this moment, only edited the patch set for proper commit message format). The imc module doesn't have an active maintainer, you can step in if you plan to work more on this module, so there is no need for additional review unless you want explicitly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1869#issuecomment-467512272