We ran into an issue recently with certificate validation and this modification to the source code helped us quickly identify the root cause. Previously we had no way of seeing which domain was invalid. I didn't like using malloc here but hopefully freeing it in the same context ensures no memory leak as well avoid any memory corruption... with the memcpy and '\0'... hope this helps...

Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• [x ] Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• [x ] Tested changes locally
• Related to issue #XXXX (replace XXXX with an open issue number)

Description

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2873

Commit Summary

• Expose the domain in certificate validation errors

File Changes

• M src/modules/tls/tls_util.h (6)

Patch Links:

• https://github.com/kamailio/kamailio/pull/2873.patch
• https://github.com/kamailio/kamailio/pull/2873.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.