@lbalaceanu commented on this pull request.


In src/modules/dialplan/dp_repl.c:

> @@ -427,6 +427,14 @@ int rule_translate(sip_msg_t *msg, str *instr, dpl_node_t *rule,
 		return 0;
 	}
 
+	if(pcre_md == NULL) {
+		pcre_md = pcre2_match_data_create(MAX_REPLACE_WITH, NULL);

Hi @linuxmaniac - thank you, I was not aware about that compile context usage you mentioned. However, I also think that because we are using a static variable we can get away with allocating via malloc/free once. Please tell me if you want it changed however.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/4289/review/2945752052@github.com>