True. Good call!
On 11/21/2011 06:23 AM, Daniel-Constantin Mierla wrote:
Hello,
thanks for the patch! It looks like a copy&paste error slipped in:
- {"reg_timer_interval", STR_PARAM, ®_timer_interval },
Should be INT_PARAM based on the type of reg_timer_interval:
- {"reg_timer_interval", INT_PARAM, ®_timer_interval },
Cheers, Daniel
On 11/21/11 12:16 PM, Alex Balashov wrote:
Module: sip-router Branch: master Commit: 455b64088b7ace99c767a3320b79f7069a3202b8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=455b6408...
Author: Alex Balashov - Diminuendo-2evariste-admins@evaristesys.com Committer: Alex Balashov - Diminuendo-2evariste-admins@evaristesys.com Date: Mon Nov 21 06:13:05 2011 -0500
Added reg_timer_interval modparam to uac to allow user to regulate the frequency with which registrations are renewed and otherwise managed. Previously, this has been hardcoded to 90 seconds.
modules_k/uac/doc/uac_admin.xml | 40 +++++++++++++++++++++++++++++++++++++++ modules_k/uac/uac.c | 2 + 2 files changed, 42 insertions(+), 0 deletions(-)
diff --git a/modules_k/uac/doc/uac_admin.xml b/modules_k/uac/doc/uac_admin.xml index da6a93d..e278be6 100644 --- a/modules_k/uac/doc/uac_admin.xml +++ b/modules_k/uac/doc/uac_admin.xml @@ -272,6 +272,7 @@ modparam("uac", "reg_db_url",
</programlisting> </example> </section> + <section id="reg-contact-addr-id"> <title><varname>reg_contact_addr</varname> (string)</title> <para> @@ -287,6 +288,45 @@ modparam("uac", "reg_contact_addr", "192.168.1.2:5080") </programlisting> </example> </section> + + <section id="reg-timer-interval-id"> + <title><varname>reg_timer_interval</varname> (string)</title> + <para> + Timer interval (in seconds) at which registrations are managed, e.g. renewed as needed. + </para> + <para> + <emphasis> + The default value is 90 seconds. + </emphasis> + </para> + + <example> + <title>Set<varname>reg_timer_inteval</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("uac", "reg_timer_interval", 60) +... + </programlisting> + </example> + </section> + + </section> + + + <section id="reg-contact-addr-id"> + <title><varname>reg_contact_addr</varname> (string)</title> + <para> + Address to be used to build contact address. Must be at least + host part, can have port and parameters. Must not include 'sip:'. + </para> + <example> + <title>Set<varname>reg_contact_addr</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("uac", "reg_contact_addr", "192.168.1.2:5080") +... + </programlisting> + </example> </section>
diff --git a/modules_k/uac/uac.c b/modules_k/uac/uac.c index 5f6112a..e1d2209 100644 --- a/modules_k/uac/uac.c +++ b/modules_k/uac/uac.c @@ -91,6 +91,7 @@ static int mod_init(void); static void mod_destroy(void); static int child_init(int rank);
+extern int reg_timer_interval;
static pv_export_t mod_pvs[] = { { {"uac_req", sizeof("uac_req")-1}, PVT_OTHER, pv_get_uac_req, pv_set_uac_req, @@ -134,6 +135,7 @@ static param_export_t params[] = { {"auth_password_avp", STR_PARAM,&auth_password_avp }, {"reg_db_url", STR_PARAM,®_db_url.s }, {"reg_contact_addr", STR_PARAM,®_contact_addr.s },
- {"reg_timer_interval", STR_PARAM, ®_timer_interval },
{0, 0, 0} };
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev