Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
@Fr-Soltanzadeh commented on this pull request.
In src/modules/rtpengine/rtpengine.c:
> @@ -3349,7 +3349,10 @@ static bencode_item_t *rtpp_function_call(bencode_buffer_t *bencbuf,
} else {
ng_flags.dict = extra_dict;
ng_flags.flags = bencode_dictionary_get(ng_flags.dict, "flags");
- bencode_dictionary_get_str(ng_flags.dict, "call-id", &ng_flags.call_id);
Ok, you mean you don't want to overwrite/reset
ng_flags.call_idif it was set already, right?
Not exactly. I want to overwrite/reset ng_flags.call_id only if ng_flags.dict contains the "call-id" key, ensuring it's never null.
I don't think using
shm_str_dupis correct though. I don't see a correspondingshm_free. Shouldn't it just beng_flags.call_id = tmp_callid;?
You're rightâshm_str_dup isn't necessary here. I updated it to directly assign tmp_callid to ng_flags.call_id. Thanks for pointing that out!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.