Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)
• Cleanup

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue #XXXX (replace XXXX with an open issue number)

Description

Redefine some flags as enum instead of separate define. This makes it easier to see what flags are accepted by functions and with the right compiler flags, the compiler will warn when the wrong flags are used.

No functional changes are intended.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2511

Commit Summary

• core/tcp: Convert RD_CONN_ flags to enum
• core/ip_addr: Reformat and redefine si_flags as bitshifts
• core/ip_addr: Convert SND_F_ flags to enum
• core/tcp: Convert F_TCP_REQ_ flags to enum

File Changes

• M src/core/ip_addr.h (18)
• M src/core/tcp_conn.h (43)
• M src/core/tcp_read.c (14)
• M src/core/tcp_read.h (14)
• M src/core/tls_hooks.h (3)
• M src/modules/tls/tls_server.c (2)
• M src/modules/tls/tls_server.h (3)

Patch Links:

• https://github.com/kamailio/kamailio/pull/2511.patch
• https://github.com/kamailio/kamailio/pull/2511.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.