> Thanks for the pull request. Just inventing a new patch category is
> not the right approach, sorry.
>
> Please just use "core" for the core part and the other module parts as
> individual commits per module with the respective module name as
> prefix.
No problem, will do.
> One small question, why do you add this additional quotes and space
> around the TIME_T_INT_FMT #define?
You mean this, right?
LM_DBG("converting datetime value %" TIME_T_INT_FMT " to str\n", VAL_TIME(v));
Below wouldn't work:
LM_DBG("converting datetime value %TIME_T_INT_FMT to str\n", VAL_TIME(v));
Or maybe I didn't understand your question?
Kind regards,
Seb
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.