@rfuchs commented on this pull request.


In src/modules/rtpengine/rtpengine.c:

> @@ -3349,7 +3349,10 @@ static bencode_item_t *rtpp_function_call(bencode_buffer_t *bencbuf,
 	} else {
 		ng_flags.dict = extra_dict;
 		ng_flags.flags = bencode_dictionary_get(ng_flags.dict, "flags");
-		bencode_dictionary_get_str(ng_flags.dict, "call-id", &ng_flags.call_id);

Ok, you mean you don't want to overwrite/reset ng_flags.call_id if it was set already, right? I don't think using shm_str_dup is correct though. I don't see a corresponding shm_free. Shouldn't it just be ng_flags.call_id = tmp_callid; ?


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/4097/review/2536949462@github.com>