Hello,
according to my tests this fixes works fine, but it would be great if
somebody else could also look to it before a backport.
Cheers,
Henning
Am 15.08.19 um 16:30 schrieb Henning Westerholt:
Module: kamailio
Branch: master
Commit: a263f5b62c03851a5d8a61f09e69745f90370703
URL:
https://github.com/kamailio/kamailio/commit/a263f5b62c03851a5d8a61f09e69745…
Author: Henning Westerholt <hw(a)skalatan.de>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-08-15T16:25:57+02:00
topos_redis: fix regression in PRACK routing (commit cfc89db53c087, GH #1784)
- fix regression in PRACK routing (introduced in cfc89db53c, GH #1784)
- result set were set to 0 before usage by a memset
---
Modified: src/modules/topos_redis/topos_redis_storage.c
---
Diff:
https://github.com/kamailio/kamailio/commit/a263f5b62c03851a5d8a61f09e69745…
Patch:
https://github.com/kamailio/kamailio/commit/a263f5b62c03851a5d8a61f09e69745…
---
diff --git a/src/modules/topos_redis/topos_redis_storage.c
b/src/modules/topos_redis/topos_redis_storage.c
index 3cc24ef558..fe366403c8 100644
--- a/src/modules/topos_redis/topos_redis_storage.c
+++ b/src/modules/topos_redis/topos_redis_storage.c
@@ -727,6 +727,7 @@ int tps_redis_load_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t
*sd,
memset(argv, 0, TPS_REDIS_NR_KEYS * sizeof(char*));
memset(argvlen, 0, TPS_REDIS_NR_KEYS * sizeof(size_t));
argc = 0;
+ memset(&id, 0, sizeof(tps_data_t));
if(mode==0) {
/* load same transaction using Via branch */
@@ -737,7 +738,6 @@ int tps_redis_load_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t
*sd,
LM_ERR("failed to load the INVITE branch value\n");
return -1;
}
- memset(&id, 0, sizeof(tps_data_t));
xvbranch1 = &id.x_vbranch1;
}
if(xvbranch1->len<=0 || xvbranch1->s==NULL) {
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev(a)lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev