@tdimitrov commented on this pull request.

Great job!

Only one remark - could you please address my comment about the hardcoded PROTO_UDP in ipsec_forward function? If it is not an error - I'll merge it.

In src/modules/ims_ipsec_pcscf/cmd.c:

> @@ -562,6 +560,24 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d)
     struct pcontact_info ci;
     pcontact_t* pcontact = NULL;
     int ret = IPSEC_CMD_FAIL; // FAIL by default
+    unsigned char dst_proto = PROTO_UDP;

Is this hardcoded to PROTO_UDP on purpose?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.